Skip to content

General Iteration #2 #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 13, 2025
Merged

General Iteration #2 #974

merged 6 commits into from
Jan 13, 2025

Conversation

@CadeusTheGreat
Copy link
Contributor

@CadeusTheGreat CadeusTheGreat commented Jan 7, 2025

Changes

Some pages have pairs and ipairs creeping back in or that were missed in my previous PR for general iteration. This PR changes them to general iteration. Will update other pages in the future to further remove references to pairs and ipairs however that work is out of scope for this PR as it will be a larger change to the docs.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@CadeusTheGreat CadeusTheGreat requested a review from a team as a code owner January 7, 2025 01:20
@github-actions github-actions bot added engine guides Changes the Engine guides resources Changes the Resources content labels Jan 7, 2025
@CadeusTheGreat CadeusTheGreat changed the title Migration to general iteration General Iteration Jan 7, 2025
@CadeusTheGreat CadeusTheGreat changed the title General Iteration General Iteration #2 Jan 7, 2025
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jan 7, 2025
@CadeusTheGreat
Copy link
Contributor Author

CadeusTheGreat commented Jan 7, 2025

Pipeline is unhappy but the changes don't look like they should cause an issue.

IgnisRBX
IgnisRBX reviewed Jan 13, 2025
View reviewed changes
IgnisRBX
IgnisRBX reviewed Jan 13, 2025
View reviewed changes
IgnisRBX
IgnisRBX previously approved these changes Jan 13, 2025
View reviewed changes
@IgnisRBX
Copy link
Contributor

IgnisRBX commented Jan 13, 2025

Thanks for the commit as always! Especially getting rid of those irritating "pairs" syntax bits. :)

@IgnisRBX IgnisRBX merged commit b7c0012 into Roblox:main Jan 13, 2025
3 checks passed
@CadeusTheGreat CadeusTheGreat deleted the General-Iteration-#2 branch January 13, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgnisRBX IgnisRBX IgnisRBX approved these changes

Assignees

No one assigned

Labels

changes requested This pull request has changes requested prior to merging engine guides Changes the Engine guides resources Changes the Resources content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CadeusTheGreat @IgnisRBX